Home › Forums › WoodMart support forum › WCAG – Missing form label in Price range filter

WCAG – Missing form label in Price range filter

Viewing 10 posts - 1 through 10 (of 10 total)
  • Author
    Posts
  • November 25, 2021 at 11:26 am #334478

    kustomgr
    Participant

    Hello there.

    I want to add two aria-labels in the price range filter that appears in the filters sidebar.

    I have found that the code appears in two places:
    1. woodmart/inc/shortcodes/product-filters.php -> lines 288-289

    <input type="hidden" class="min_price" name="min_price" value="' . esc_attr( $min_price ) . '" data-min="' . esc_attr( $min ) . '">
							<input type="hidden" class="max_price" name="max_price" value="' . esc_attr( $max_price ) . '" data-max="' . esc_attr( $max ) . '">

    2. woodmart/inc/integrations/elementor/elements/class-product-filters.php -> lines 557-558

    <input type="hidden" class="min_price" name="min_price" value="<?php echo esc_attr( $min_price ); ?>" data-min="<?php echo esc_attr( $min ); ?>">
						<input type="hidden" class="max_price" name="max_price" value="<?php echo esc_attr( $max_price ); ?>" data-max="<?php echo esc_attr( $max ); ?>">

    Even though I have overrided these two particular templates and added the aria-labels I wanted, when I refresh my shop page, the aria-labels are not showing up.

    How can I achieve what I want?

    I have to create the e-shop with zero errors in the https://wave.webaim.org/ tool.

    Thanks in advance.

    Attachments:
    You must be logged in to view attached files.
    November 25, 2021 at 2:31 pm #334588

    Luke Nielsen
    Keymaster

    Hello,

    Thank you for reaching out to us!

    Please send us the URL link to your site, and provide login access for your site’s WordPress admin panel, so we can log in and check the issue from the “Wave” services on your side.

    Kind Regards

    November 25, 2021 at 5:02 pm #334619

    kustomgr
    Participant

    Sure.

    November 26, 2021 at 2:31 pm #334922

    Luke Nielsen
    Keymaster

    Hello,

    On the shop page, I found 2 errors that you describe above. Please, try to check these errors on the default WordPress theme just to check whether the issue is with our theme or not.

    https://monosnap.com/file/IcZ5HyPhStJcZo6yEhmDQMuPGauljl

    https://monosnap.com/file/HowRq4tiSWXr6yh4vVgCszP63ma3k1

    To be able to fix 3 errors on the home page, you should edit your contact form and add a form label or you can create a new contact form and replace it in your builder.

    https://monosnap.com/file/at41iQyWcGHXT0y4pD9duXwSuhTT3U

    https://monosnap.com/file/H6JKL58pz5Xo2YRkDTvUfj26WXKLGp

    https://monosnap.com/file/Vsn5pcFycIaLoTDG0MCXcT49LJCPOt

    Kind Regards

    November 26, 2021 at 2:34 pm #334925

    kustomgr
    Participant

    On the shop page, I found 2 errors that you describe above. Please, try to check these errors on the default WordPress theme just to check whether the issue is with our theme or not.

    The error is from your theme because your theme shows the price filter functionality.

    To be able to fix 3 errors on the home page, you should edit your contact form and add a form label or you can create a new contact form and replace it in your builder.

    Yes, I know what I have to do about the errors regarding the contact form. Thanks.

    I want to find a solution about the price slider error, this is what make me struggle.

    November 26, 2021 at 3:10 pm #334935

    Luke Nielsen
    Keymaster

    Hello,

    The price filter functionality comes from WooCommerce, so if you check it on the default theme and the issue will be the same then try to contact the WooCommerce support team.

    Kind Regards

    November 27, 2021 at 9:54 am #335090

    kustomgr
    Participant

    Well, I tried to replicate the issue with twenty twenty one theme but I could not show the price filter in order to check with the wave tool.

    Can you please tell me what it needs to be done and in which template should I add the aria-label?

    November 29, 2021 at 10:58 am #335412

    Luke Nielsen
    Keymaster

    Hello,

    Please, check the issue on the Storefront theme.

    Unfortunately, we can’t edit errors from WooCommerce because we can break something and the site will not work correctly.

    Kind Regards

    November 29, 2021 at 11:09 am #335419

    kustomgr
    Participant

    Well, this can’t be a woocommerce issue because I overwrite both your theme’s files AND the woocommerce template for product filter and nothing happened.

    Maybe it’s something between your js files that are creating the price filter?

    The same issue appears in your demos as well:
    1. LINK
    &
    2. LINK 2

    November 29, 2021 at 3:38 pm #335526

    Luke Nielsen
    Keymaster

    Hello,

    I have mentioned above that the price filter comes from WooCommerce, so I checked this issue on the default “Storefront” theme by WooCommerce.

    https://monosnap.com/file/vueeIpt7cFtYAnkK04xTh9J66k6CMY

    On this screenshot, you can see the same issue. You need to contact their support and when they fix this issue you just update the “WooCommerce” plugin and the issue will be gone.

    Kind Regards

  • Author
    Posts
Viewing 10 posts - 1 through 10 (of 10 total)