Possible bugs with version 6.5.0

[metuza]

Hello,

I have earlier today updated to v6.5.0 on one of my sites and have found the following issues in which can not be found in my other 2 sites with mostly uses the same settings and wp rocket.

1. The p.stock class now has a span element set with class display: inline-flex. This will cause problems for all users using custom stock messages. Like myself using messages like this: Product is out of stock.<br/><small>Will be back in stock 02.06.2022.</small>. Message now shows as one line.

2. In mobile view the logo in header has dissapeared when wp rocket is in use. No logo in mobile vertical view, but if i just lay mobile horisontally the logo appear back, but dissapear again when mobile turned vertically.

3. No longer sticky header in desktop and mobile view if wp rocket in use.

4. The new option to display visitors on single products has issues with counting, it just adds +1 on each page refresh. So i got 7 visitors when there should be only 1. Then when i enabled refresh every 10 seconds it just jumped between 6 and 7, up/down every 10 sec.

5. The most important findings. A while ago wp rocket added some fixes for click on links if the delayed JS option is enabled. In my mobile if i clicked menu it opened instantly the same if i clicked minicart icon the popup opened instantly. But now with version 6.5.0 i need in mobile to click as with older wp rocket, 2-3 times before anything happens.

You can test and compare issue 5 in my updated site http://www.villmarksbua.no and my not updated site http://www.arctic-fritid.no you will then see that in http://www.arctic-fritid.no any click on menu link or minicart icon will work instantly. (use a real mobile). Both sites has the exact same wp rocket settings.

The updated site has been tested with all plugins disabled (except wp rocket), but still the same issues.

Brgds
Rune

• This topic was modified 2 years, 11 months ago by metuza.

Hello,

1. Please, send a direct link to the page where we can see this.

2. 3. 5. Please, enable WP Rocket so we can see this.

4. Also enable this option on your website so we can test how it works.

Kind Regards

Hello,

1. Can bee seen here, or any other product page: https://www.villmarksbua.no/produkt/videreforedling/tilbehor-til-videreforedling/royksyre-150ml/ BUT i have fixed it using custom CSS.
.single-product p.stock span {
display: block;
}

2,3 and 5. WP Rocket is already enabled so you will see it in https://www.villmarksbua.no (or any other page) that there is no sticky header in both mobile and desktop. To see the logo issue you need to use a real mobile in vertical and horisontal view. You will not see the logo issue if using browser tools.

In regards to the multiple click issue to open ie. minicart popup you will see that using a real mobile, ie. iPhone. Then compare villmarksbua.no with arctic-fritid.no

4. The visitor counter is now enabled.

I have added login credentials if you need to login. Feel free to test everything.

Brgds
Rune

2. It is affected by some lazy loading feature that is not related to our theme.

3. Please, send us your FTP access so we can check what is wrong with the sticky header.

4. We don’t see a problem with this on your website. Please, record some video if possible so we can check what is wrong.

5. It works with the first click now. But it has some small delays because of the loading of all JS scripts. That is how the WP Rocket works and our theme doesn’t influence anything here.

Kind Regards

2. Logo issue is related to delay JS of WP Rocket, or a combination of wp rockets lazyloading and delay JS. When i deactivate delay JS it is all OK, also the sticky header. So i guess you have done some exclusions for delay JS, in which already is handled by WP Rocket?

3. As mentioned in #2 above the sticky header works ok if I deactivate delay JS in wp rocket. Seems to me that some js is excluded / delayed in which should not be delayed because often logo and sticky header start working by itself after a while but then dissapear again on page refresh.

4. Well, i do not have any video options but tested again visited a product from mobile and 2 other desktop browsers. It should then show 2-3 visitors but every 10 sec the number just added up in all 3 browsers.

5. Yes works 90% ok, but sometimes the minicart needs 3-4 clicks before it opens. And this is specifically for mobile and seems to be related to the logo and sticky header issue. I have noticed that pages where logo is loaded there menu and minicart links works ok on first click with just a little delay.

So actually it seems to me that issue #5 , logo and sticky header issue is all related to the same problem. Because you wont find any of them problematic if logo is ok. If logo/sticky header is loading ok then also menu and minicart is instantly opened, and visa/versa.

Brgds
Rune

Just a follow up to my above message. I have just now updated to v6.5.0 on my second site https://www.barbiq.no and did find the exact same issue there. Sticky header and logo not working and on pages with these issues i have to click multiple times on menu and minicart. So it is for sure an issue with v6.5.0

Brgds
Rune

[metuza]

Well i had a feeling that some JS files was excluded from WP Rocket delay JS option so i scanned your code and did find this file: /wp-content/themes/woodmart/inc/integrations/rocket.php

In this file i just commented out the filter: add_filter( ‘rocket_delay_js_exclusions’, ‘woodmart_delay_js_exclusions’ );

So now everything works 100% perfectly fine. Also my pagspeed went up again to all green.

Why is all these js files excluded? I have never noticed any issues related to these JS files as excluded, UNLESS when using the WP Rocket option Remove unused CSS, but all these eventually issues was easy to fix by excluding CSS files or classes.

Brgds
Rune

• This reply was modified 2 years, 11 months ago by metuza.

2. The problem with the lazy loading. You need to disable it in WP Rocket and use our theme lazy loading instead.

3. 5. Please, send us your FTP access so we can check the sticky header issue.

4. We tested this on your website but it always shows a static number of visitors and doesn’t increase with time.

As for the delay JS, we excluded all files that usually needs to be loaded initially without delay. But we will make this feature optional in our next theme update. Anyway, it should work without any problems when it turned on.

Kind Regards

Your lazy loading does not work that good as wp rocket. But as mentioned all my problems is solved now after i commented out the filter: add_filter( ‘rocket_delay_js_exclusions’, ‘woodmart_delay_js_exclusions’ );

It also took my site back again to all green 94/98 on google pagespeed.

So if you have a way that i can deactivate the above filter in my functions.php that would be great. The standard remove_filter did not work.

Brgds
Rune

In this case, just remove this code if it works well for you. Anyway, we will introduce an option for this in Theme Settings that will be turned off by default.

Kind Regards

Sounds great, thank you!

Brgds
Rune

You are welcome!
Feel free to contact us if you have any further questions.

[Author]

Posts