Home Forums Basel – Premium Template sales-flash in loop uses wrong translation

This topic contains 1 reply, has 2 voices, and was last updated by Artem Temos Artem Temos 9 months, 1 week ago.

Viewing 2 posts - 1 through 2 (of 2 total)
  • Author
    Posts
  • #8740

    emaix
    Participant

    Hello.

    There’s a difference in translations on the word ‘sale’. In english the word sale can mean several things: A sale = someone purchased something, and: On sale = a product with a discounted price. It seems to me that the woocommerce translation ‘sale’ = a sale and ‘sale!’ = a discounted price.

    The problem is only in the loop:

    loop/sale-flash.php:

    echo apply_filters( ‘woocommerce_sale_flash’, ‘<span class=”onsale”>’ . __( ‘Sale’, ‘woocommerce’ ) . ‘</span>’, $post, $product );

    Sould be:

    echo apply_filters( ‘woocommerce_sale_flash’, ‘<span class=”onsale”>’ . __( ‘Sale!’, ‘woocommerce’ ) . ‘</span>’, $post, $product );

    missing the exclamation mark.

    WooCommerce source:

    https://github.com/woocommerce/woocommerce/search?utf8=%E2%9C%93&q=woocommerce_sale_flash

    Thank you

    #8747
    Artem Temos
    Artem Temos
    Keymaster

    Hello,

    Thank you for reporting us about the issue.

    We will consider changing this word in our next theme update. For now, we suggest you simply copy this file to the child theme and change this word to Sale!.

    Kind Regards

Viewing 2 posts - 1 through 2 (of 2 total)

You must be logged in to reply to this topic.