Home Forums WoodMart support forum functions.php

functions.php

Viewing 30 posts - 1 through 30 (of 33 total)
  • Author
    Posts
  • #321110

    pierredemeudon
    Participant

    Hi,
    Could you please explain why “add_theme_support( ‘align-wide’ ); ” in not included in woodmart?
    Kind regards

    #321113

    Hello,

    Please describe your purpose in more detail, what do you want to change? Please provide a page URL and screen showing what and how you want to change.

    We will check and suggest the option.

    Best Regards

    #321139

    pierredemeudon
    Participant

    Hello,
    OK.

    Context:
    In short, WPBakery is no more viable.
    1. we discussed in June the problem of the incompability between woodmart widgets and gutenberg, leading to crashes. You answered me somehow “you have to live with it”. Finally, you have been forced to change. No other choice, WP is driving the game.
    2. Now, my problem is a growing number of conflicts between wpbakery, WP / gutenberg, and WPML (ie translations disappearing, visual editor not working, …). Some plugins also don’t work anymore with wpbakery, only within the WP environment (for pages or articles). After, fact is that WPBakery is slower, and an horror for CPU. So, I am switching my pages from WPbakery to sane WP / Gutenberg. And thus be ready for the shortly coming future, and perform better.

    Problem:
    With WPBakery, I can have a full-width row in a non full-width page or article (because of sidebar). Ie a row going outside the editing zone. And as of now, with Gutenberg / WP core editor, I can’t. And this is because “add_theme_support(‘align-wide’);” should be added within the functions.php of the theme. And it’s not.

    How to manage?

    Kind regards

    #321247

    Hello,

    Please install the Classic Editor plugin, it is free, and check how your widgets work.

    What do you mean by “WP bakery page builder is not available”, please provide your site admin access, insert the credentials into the Private content below the message area and provide a page, product or post URL where I can see the problem.

    If there is an incompatibility of WPML with any other plugin, please contact WPML support on this issue, or the theme does not influence or have any tools to fix that.

    If you have any questions please feel free to contact us.

    Best Regards

    #321277

    pierredemeudon
    Participant

    Hi,

    1. You have not read.
    I did not write that “WP bakery page builder is not available”. But viable! Use it in Gutenberg, ie coming wordpress, generates more and more problems.

    2. Recommend to use “Classic Editor”, which is something of 20th century and virtually dead is, sorry, a non-sense if not stupid.

    Questions:
    Q1: why “add_theme_support( ‘align-wide’ ); ” in not included in woodmart?
    Q2: how to “add_theme_support( ‘align-wide’ ); ” within theme?
    Q3: What are the consequences on other aspects of the theme if done?

    Kind regards

    #321411

    Hello,

    I have checked with the development department and these will be added to the next release.

    If you have any questions please feel free to contact us.

    Best Regards

    #321442

    pierredemeudon
    Participant

    Hi,
    Q1: Do you mean precisely that “add_theme_support( ‘align-wide’ ); ” will ba added within functions.php of Woodmart?
    Q2: when do you plan next release?
    Kind regards

    #321500

    Hello,

    Yes, we ad the file we expect the new release in a month approximately, it can be a git later.

    If you have any questions please feel free to contact us.

    Best Regards

    #334309

    pierredemeudon
    Participant

    Hi There,

    Sorry, I resuscitate this topic. I saw that you made changes with 6.2, but there is no solution to above, and there are new different issues. I am sure that it’s due to 6.2, because the problems disappear if I switch back to Basel or old Woodmart for instance.

    1. The layout of gutenberg editor is broken.
    This is how it looks like:
    https://snipboard.io/7F2V50.jpg
    – The editor has no padding, what is not comfortable to say the least
    – the right menu is somehow broken, becoming huge rectangles

    2. the block width options are there, but don’t work
    What is new is that, for certain blocks, 2 new options align wide, and full width.
    But if options are there, it has no impact.

    Waiting for your feedback
    Kind regards

    #334380

    Hello,

    Our theme is based on the Elementor or WP Bakery page builder, as for the Gutenberg section, please check the section settings.

    The recent theme version is 6.2.4 please update and check.

    Best Regards

    #334393

    pierredemeudon
    Participant

    Hello,
    I don’t understand. Gutenberg is in wordpress and about blocks.
    Which section do you talk about?

    #334486

    Hello,

    Please deactivate all the plugins except these ones:

    Slider Revolution
    WPBakery Page Builder or Elementor
    Woodmart Core
    Contact Form 7
    MailChimp for WordPress
    WooCommerce
    Safe SVG

    If the problem has gone, activate the plugins one by one, checking the issue to detect which one causes the problem.

    In case, the problem remains, even after all the plugins are deactivated, provide your site admin access (insert the site credentials into the Private content block under the message area) and confirm the permission for plugins deactivation, switching to the parent or default theme. As soon as we complete the testing we will enable all back, however, the site would be without plugins for 15-20 min. You would better make the full backup of your site.

    Best Regards

    #334585

    pierredemeudon
    Participant

    Hi,

    Thank you for this more positive welcome.
    I have a staging site, you can play there as you want.
    With all plugins deactivated, the problem remains. This is purely due to Woodmart 6.

    As a reminder:

    1. As of now, WP editor (ie gutenberg) is consensually delivering much faster pageload than elementor or wpbakery for users. And for webmasters, it’s also much less resource intensive (CPU / RAM). And anyway, that’s the core and the future. What will become even more obvious with phases 3 and 4.

    2. Woodmart 5.x and former do not enable to use certain capabilities of this editor which are described here:
    https://developer.wordpress.org/block-editor/how-to-guides/themes/theme-support/#wide-alignment

    3. Woodmart 6.x goes in the right direction, but with errors:
    * it’s not wysiwyg as claimed (you can check)
    * align wide & full width are now in block options, but it has no impact on the lay out
    * it breaks the layout of sidebar (to check, select an image, and see the layout of the right sidebar)
    * there is no padding, and so, texts / images are sticking to right and left sidebars.
    * the theme options (your custom meta box for page / articles) are also interfering. When switching from desktop, to mobile, to desktop again, it goes into the text, rather than remain on bottom. And normally, they should be on the side panel, like all others do, no?

    Credentials in dedicated zone

    Kind regards

    #334587

    pierredemeudon
    Participant

    ps: for your checks and tests, you may take a recent article like “couleur corail”.

    You may need to activate generateblocks (all plugins now deactivated).

    #334875

    Hello,

    Our developers now are working to ensure more compatibility and support.

    Best Regards

    #336236

    pierredemeudon
    Participant

    Hello,
    When do you plan to revert to me?
    Kind regards

    #336413

    Hello,

    We are terribly sorry for the delay.

    As for Gutenberg, as we mentioned above we are planning to expand this builder support.

    Regarding the full-width, we have checked this option and it works properly: https://gyazo.com/1d8866ed73912c829827ae17dc216bc8 and https://gyazo.com/9f04a14e6ef599bb264114e5fb0e46f1

    * it’s not wysiwyg as claimed (you can check) – please provide more details with the screens or video;
    * align wide & full width are now in block options, but it has no impact on the lay out – we have tested and see the full-width works properly: https://gyazo.com/1d8866ed73912c829827ae17dc216bc8 https://gyazo.com/9f04a14e6ef599bb264114e5fb0e46f1.

    * it breaks the layout of sidebar (to check, select an image, and see the layout of the right sidebar) – we will fix this if it is caused by our theme.
    * there is no padding, and so, texts / images are sticking to right and left sidebars.
    * the theme options (your custom meta box for page / articles) are also interfering.
    – – please give more details with the screen or video

    Best Regards

    #336548

    pierredemeudon
    Participant

    Hello,

    No problem for the timing. This topic is very important for me, but it’s not urgent.

    First, you did not what I proposed, in that you took my front page (designed with Wpbakery), rather than the article I suggested (couleur corail), which is designed from scratch with Gutenberg.
    In this article, as written before, the full-width option is rightly available for an image block and can be chosen:
    https://snipboard.io/Kijhxe.jpg
    Though, if I click on preview, this is what I have, the block is not full width:
    https://snipboard.io/TvyiYw.jpg
    With Wpbakery, it’s different (all other things equal): if I choose full width for a row, I get it full width; this is an image from another article, made with Wpbarery (same plugins / theme / site):
    https://snipboard.io/TaoC7e.jpg
    => The expectation is to have full width with Gutenberg as I can have full width with WPbakery, To eliminate and unload WPbakery. By the way, if you worked on my front page, you should have noticed that it breaks the site (wpbakery) for a cc. 1 mn (RAM / CPU in red). And if you edit page “galerie des tissus”, which is heavier but made with gutenberg, it’s works smoothly.

    Re. wysiwig, this is what above images say: When built with gutenberg, a full-width block on editor is not full-width in real / life.

    Next, menus. Now, plugins put their settings in the right panel, you may see here for complianz (cookies), and easy table of content (table des matières):
    https://snipboard.io/QIWCAV.jpg
    You probably did not notice it because all plugins are deactivated on staging (and you reactivate).

    When they are not, you get this, when swoping from desktop to mobile view, and then back to desktop again;
    https://snipboard.io/nNwRcg.jpg
    But as you see, it’s the case for your theme, but also for WPML or a copyright plugin I use.

    Broken Layout of side bar. As written earlier, this is 100% due to Woodmart since 6.2. Here the view with your Basel:
    https://snipboard.io/MefDn1.jpg
    the rectangles in side bar have a normal size. Note also that the editor has padding, text is not sticking to the borders, what is what I had with woodmart 6.1, and is far more comfortable to work with
    https://snipboard.io/MefDn1.jpg

    What may be useful here for you at this stage… the full-width setting that was defined via Woodmart remains active in editor with Basel, though Basel does not propose it. Though, if you go to preview, the image block is not full width in “real life”

    Hoping it’s clear, and if not, let me know
    Best regards
    https://snipboard.io/EraVCd.jpg

    https://snipboard.io/EraVCd.jpg

    Re.

    #336645

    Bogdan Donovan
    Keymaster

    Hi,

    1. Wide ang full width.
    WPBakery full width rows and Gutenberg full width section designed in different ways.

    WPBakery uses JS script to calculate viewport width and stretch content with “width” parameter, ignoring all adjacent content. Following JS also recalculate row width, then screen resolution is changed.

    Gutenbeg didn’t use any JS and provide only CSS class which indicated the state of the current section. Without JS script, width of sidebar can’t be calculated on all possible device screen width without side displacements and overlapping of main content. Any other methods using “floated” sidebars can’t be done in complex WordPress themes that uses Bootstrap 4 without braking site layout.

    In that case, Gutenberg wide and full width options working only if there is no sidebar on page. (please, check the video https://gyazo.com/db784187dffbc592ad57f01a05cb2d3b). You can see similar behavior with default WordPress themes. For example, Twenty Twenty-One: didn’t have sidebar – wide and full width is working. Storefront: have sidebar – wide and full width isn’t working.

    2. Oversized select element in Gutenberg editor.
    This issue will be fixed in the next theme update.

    3. Position of Woodmart metaboxes.
    Woodmart post-type metaboxes area have complex structure that can contain wide variety of options tools including sliders, tabs, button-switches, color-picker, image and image gallery picker. Alongside with Gutenberg, it also masts support other Page Builders like WPBakery and Elementor. In that case, to save it flexibility and versatility, it location need to have enough space for all it options.

    4. Metaboxes overlaps page content.
    We have checked the following issue and didn’t fount it. Check the video. (https://gyazo.com/84a5d34d3ac685081ce9d3e90b740194). Please, record the video or provide us with steps how to reproduce it.

    Kind Regards

    #336752

    pierredemeudon
    Participant

    Hi,

    I am not a Tech and js / css are a remote galaxy for me.

    1. What you say, basically, is that, with woodmart, there is no way to have a full width block with Gutenberg if there is a sidebar. Even if the site is set on boxed content.Correct?

    2. OK. When approx?

    3 OK

    4. You could not see the overlap issue since all plugins are deactivated, and you should have re-activated them as permitted. To get it, go on same article, take a block with photo, switch to mobile view, change the % width, and go back to desktop view. See where to click here:
    https://snipboard.io/lMIf2L.jpg

    5. If 1 is correct, then it’s impossible to be wysiwyg, considering that nobody would use woodmart without any sidebar. Correct?

    6. how to have the gutenberg editor as before, ie not full width, even on a 27″ screen. I.e. like it was on woodmart 6.1 or like is now on Basel?

    7. When I switch theme to storefront, switch back to Woodmart and go to widget area, it completely breaks the site (CPU / RAM explode). Why?

    Kind regards

    #337114

    Bogdan Donovan
    Keymaster

    1. Gutenberg full width/wide options are not applying only if sidebar are present on page. Site width: Boxed option didn’t influence on sidebar visibility and position, so full width/wide behavior will be the same.

    2. Approximately next month.

    4. Woodmart theme metabox are using default bottom metabox positions. There are no modifications to this position in our theme. Following issue is caused by third party plugin. We recommend you to disable it or contact with plugin support.

    5. Woodmart theme completely supports Gutenberg editor like any other default WordPress theme including Storefront, Twenty Twenty-One or any other popular e-commerce theme on Envato market.

    6. Woodmart theme didn’t influence following behavior. If you want to change editor layout, try to change it in editor options via Editor page => Options => Full screen mode. (https://gyazo.com/1b0716af4b53a58047a2cf0b22c692fe).

    7. Since WordPress 5.8 added block-based widgets witch changes widget editor backed view. The new widget layout loads widgets from the site’s frontend via iframe, creating separate requests for each widget. This behavior is normal for current WordPress version and can’t be changed via WordPress theme. The only difference is that Woodmart theme have much more widget areas than Storefront theme. It is possible that WordPress will improve this in the future.

    Kind Regards

    #337212

    pierredemeudon
    Participant

    Hi,

    1. Say OK

    2. OK

    4. I double checked. A plugin like Rank Math manages it differently and is much better integrated within Gutenberg, and their options are not less complicated than woodmart’s. What you do is not the best practise, and is far to be well integrated with WP / Gutenberg, but fact is that WPLM is another “bad” pupîl as written above. Sooner or later, you will be forced to switch, like you were for widgets
    https://snipboard.io/aBAXJ4.jpg
    https://snipboard.io/75cqga.jpg
    So, Woodmart is not incompatible, but not optimally integrated within WP / Gutenberg

    5 and 6. This is definitively false
    This is the current view, say Woodmart with the mininum of plugins:
    https://snipboard.io/MlrnWB.jpg
    The view with Woodmart and 0 plugin. => plugins have no impact of plugin layout
    https://snipboard.io/c8W1ro.jpg
    The view with default theme (Storefront) and 0 plugin. Different and better => Woodmart negatively changes the layout of the editor. Btw, Basel delivers same layout than default theme
    https://snipboard.io/EytnD4.jpg

    7. You did not read, and did not accept but reality if that Woodmart widgets can break my site. If you want to reproduce: once on WD theme, reinstall the widgets are they are on original site (polinacouture.com). Then, change theme to Storefront. Then move back to Woodmart. And then go to WP / widgets. And then drop me an email because it will be so broken that I will need the server’s staff to restore it.

    Waiting for yor feedback

    Best regards

    #337360

    Bogdan Donovan
    Keymaster

    Hi,

    4. As you can see from your screenshot, (https://snipboard.io/nNwRcg.jpg) you have other plugin that use bottom metabox position “Configuration du contenu multingue” and “Copiright / Ownership / Licensing” and their position was also changed by third party plugin. Woodmart theme does not affect this behavior, and it can’t be fixed via theme. If metabox position was changed by third party plugin, we recommend you to contact with following plugin support to fix this issue.

    5-6. As was mentioned in theme changelog, ““Gutenberg” backend editor now matches styles from theme frontend” (https://prnt.sc/220v3m6). That mean that Gutenberg editor backed now styled to match sites fronted as close as possible. For now, editor inherits theme settings options like
    – Container width from “Site width” option.
    – “Site background” option.
    – “Typography” options titles, content font size and font color.

    The following changes were done to match Envato WordPress Gutenberg Requirements https://prnt.sc/224gfd1 (https://help.author.envato.com/hc/en-us/articles/360020255992).

    - Make sure that the Gutenberg editor is styled to match the frontend output as closely as possible. This should include any fonts used and any dynamic styles coming from settings etc.
    - Change the editor widths to match the widths used in the theme as closely as possible.

    7. As was mentioned in following reply (https://xtemos.com/forums/topic/functions-php/#post-337114) new block-based WordPress widgets creates large amount request for each widget present on your site.

    Only difference from default WordPress themes is in amount of widgets present on your widget editor interface: 1-2 sidebar widget area in Storefront\Twenty Twenty-One themes and over 10-16 widget areas (like Blog, Shop, Filters, Single product, Footer and etc.) in modern e-commerce themes. More widget areas with widget you have on your site – more request it creates and in this situation some hosting provider may face performance issues. Following issue can’t be fixed via WordPress theme and in some way WordPress will improve this in the future.

    For now, you can use the following “Classic Widgets” plugin (https://wordpress.org/plugins/classic-widgets/) that brings back old widget editor interface without requests spam issue.

    Kind Regards

    #337504

    pierredemeudon
    Participant

    Hi,

    4. Yes, I agree, I had written this to you before. But as I wrote also, it’s not because “bad” pupils do “bad” things, that you shall not do like “good pupils”. You may consider this as “integrate any editor screen controls/content seamlessly with Gutenberg”, like Envato says.

    5-6. You can’t say that it’s matching, nor that it’s close.
    Envato writes: “Make sure that the Gutenberg editor is styled to match the frontend output as closely as possible”. So, it’s not “must match”, it is “get as close as possible”.
    I attach 2 examples, just to show that back and front end are very different, and not close.
    From factual perspective, what I get via Storefront or Basel, on editor, is far much closer to
    final output than what I get now with Woodmart. I add an image (ex with basel) so that you see how much it’s closer to final layout with your other theme.
    Last, beyond not wysiwyg, not close, the main problem is the ergonomy, which is extremely incomfortable on many aspects, namely because too close to borders what makes block or text selection very difficult, and as well poorer readibility.
    Sorry, here, I see no benefit, but several problems.

    7. I better understand now. Now is Christmas period, not the best moment to try things breaking the site, but this plugin could be very interesting, and I thank you for this tip

    Kind regards

    Attachments:
    You must be logged in to view attached files.
    #337657

    Bogdan Donovan
    Keymaster

    Hi,

    4. The following issue is caused after using plugin functionality. By default, Gutenberg editor does not have functionality that causing issues on your site. Woodmart theme supports default Gutenberg functionality. Unfortunately, if the issue is caused by plugin, it can’t be fixes via WordPress theme.

    5-6. As ware sad in “Envato WordPress Gutenberg Requirements”.
    Change the editor widths to match the widths used in the theme as closely as possible.

    That mean Gutenberg editor container width will be matching the width that you have set in your “Site Width” option in Theme Settings. You have chosen one of the predefined Site Width options – “Full Width” (screenshot https://prnt.sc/229ql56) that makes your theme width 1222px (screenshot https://prnt.sc/229qtlj). That same width is applying to editor container – 1222px (screenshot https://prnt.sc/229r2ff) to match the widths used in the theme. The following functionality was recommended by Envato and constantly requested by our clients since release of Gutenberg, and this changes can’t be undone.

    The main difference in the screenshots you provide (https://prnt.sc/229ssw7) is that in your “Real View” you use the sidebar alongside with content. If you disable sidebar, your content width will be match theme width, and it also will match “Editor view” width.

    For now, Gutenberg didn’t allow us to somehow detect the presence of sidebar on site’s frontend and because of that, sidebar width can’t be subtracted from editor container width. If Gutenberg allows us to do so, the following width changes will be applied.

    Kind Regards

    #337678

    pierredemeudon
    Participant

    Hi,

    4. You say that this is due to plugin and WD works fine with Gutenberg and follows WP guidelines. I say that there is a conflict between WD and WP / Gutenberg, because the guideline is PluginSidebar. All any tool / plugin using PluginSidebar, no issue With tools / plugins not using it, like WPML or WD, problems

    5-6 – whatever the reasons, reality is that, with woodmart 6.2:
    – Gutenberg editor is more far less wysiwyg
    – it’s far less convenient to use, irritating, time wasting, …
    Maybe, for the happy few using WD without side bar, it will be … wonderful, but I doubt because even for them, the incomfort -eg in block / text selection- is there

    When the directives are against ergonomy and performance ….

    By the way, gutenberg editor is not made to be wysiwyg. That’s why there is this “preview”.

    So, definitively negative. Only new problems, for 0 added benefit.

    Kind regards

    #338120

    pierredemeudon
    Participant

    Indeed, after few more investigations ….
    If theme was enabling to:
    1. Define container Width / Content Width / Sidebar Width
    2. overall layout specifically on blog, pages, product archives.
    Bad game
    Kind regards

    #338445

    Bogdan Donovan
    Keymaster

    Hi,

    1-2.

    – Site width can be controlled via “Site width” option (https://prnt.sc/22l0st3)
    – Content width and Sidebar width cant be controlled separately because they are both depend on presence of each other and can be set only in proportion (if sidebar take 25% of site width, content take all remaining space – 75%, and so on). To stay responsive on all possible devices, content and sidebar width can only be set in relative values like percent. For now, our theme has thee different predefined proportion for content/sidebar width which is created according to Bootstrap 12 column proportion system (https://getbootstrap.com/docs/4.0/layout/grid/) that can be controlled via “Sidebar size” option (https://prnt.sc/22l12ah).

    Large: content width – 66.666667%, sidebar width – 33.333333%.
    Medium: content width – 75%, sidebar width – 25%.
    Small: content width – 83.333333%, sidebar width – 16.666667%.

    Alongside with general layout, the following option also present on blog, shop page, single product, and it also can be overwritten on individual posts and pages via metabox options (https://prnt.sc/22l3xas). More complex rules combination also can be assigned via our theme settings presets options (https://prnt.sc/22l4gga).

    Any other custom content\sidebar proportion options will be considered as a feature request.

    4. Bottom metabox position is not something prohibited or dissolved in Gutenberg editor. All themes and plugins can use this position via standard WordPress functions, including Gutenberg editor interface, since it is defaults Gutenberg functionality. If the following plugin didn’t support default Gutenberg functionality like bottom metabox position, it needs to be fixed in the following plugin. We recommend you to contact with plugin support to fix this issue.

    5-6. You can check default theme “Twenty Twenty-One” to see how it works.

    Backend and frontend styles (background, typography) are inherited: video (https://gyazo.com/1becc20edc21765395a789d28567937b).
    Theme width are inherited: screenshots (https://prnt.sc/22kkdxx, https://prnt.sc/22kl2h5).

    In the vision of WordPress Gutenberg is not a simple WYSIWYG text editor (like Microsoft Word or Google Docs), it only looks like that if the theme didn’t support it the latest features. WordPress creates Gutenberg like an alternative to the page builders (like WPBakery or Elementor): Article (https://wordpress.com/go/website-building/gutenberg-vs-page-builders-which-to-choose/).

    By now, WordPress is in process of integrating Gutenberg (aka Block Editor) to the new areas of site (latest was integration of block-based widgets). In the end, main goal of WordPress to create full-site editing via Block Editor with ability to edit any area of site via Gutenberg including Header, Footer, Content, Widgets, Navigation etc. Article (https://raidboxes.io/en/blog/wordpress/wordpress-site-editor/). In this situation, frontend styles need to be inherited on the backend. This how default WordPress themes work, these are also required by Envato and our clients.

    Block editor is constantly changing from update to update and in current situation Gutenberg didn’t allow us to somehow detect the presence of sidebar on site’s frontend and because of that, sidebar width can’t be subtracted from editor container width. If Gutenberg allows us to do so, the following width changes will be applied. We will consider your request as a feature request.

    Kind Regards

    #338591

    pierredemeudon
    Participant

    Hi,

    4. I can’t judge. It’s what happens too often, say “it is not me”., check other plugin, theme, server, … I read the guidelines. You don’t follow the “best practice” but it is not forbidden. Other may argue “it is not the best practice”. Dead end of users. Anyway, you will have to change, sooner or later.

    Others: since woodmart 6.2, gutenberg editor changed as image : very hard to read (text sticking to borders and full screen) + hard to select (background + blocks sticking to border) + rendering sthg much farer from reality + the totally deformed Gutenberg sidebar …

    I say it’s awfull, time wasting. You answer: not our fault, you have to live with it.

    Please, don’t ask me to change my review.

    PS: i tried to change the layout of an article using your metabox to declare right sidebar. No impact on the layout

    In short, you say not my fault.

    #338594

    pierredemeudon
    Participant

    forgot the image to show what you did with editor

    Attachments:
    You must be logged in to view attached files.
Viewing 30 posts - 1 through 30 (of 33 total)